Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend: Add genCoupons helper, other cleanups #9

Merged
merged 1 commit into from
Oct 18, 2024
Merged

backend: Add genCoupons helper, other cleanups #9

merged 1 commit into from
Oct 18, 2024

Conversation

matevz
Copy link
Member

@matevz matevz commented Oct 18, 2024

This PR adds:

  • genCoupons() lets you generate n coupons of length l
  • rename fundContract() -> fundAccount since it can be used for any address
  • remove fundGaslessAccount() since it's redundant ^^
  • setGaslessKeypair() doesn't require address anymore, becuase it can be derived from the secret directly

@matevz
backend: Add genCoupons helper, other cleanups
deb0004 
- genCoupons lets you generate n coupons of length l
- fundContract -> fundAccount since it can be used for any address
- setGaslessKeypair remove address, derived from secret directly
@matevz matevz requested a review from ZigaMr October 18, 2024 15:46
ZigaMr
ZigaMr reviewed Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@ZigaMr ZigaMr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with changes, fundGaslessAccount was indeed incorrectly named since it was also used for funding ordinary accounts/rewards.

ZigaMr
ZigaMr approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@ZigaMr ZigaMr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with changes, fundGaslessAccount was indeed incorrectly named since it was also used for funding ordinary accounts/rewards.

@matevz matevz merged commit 8c4ed87 into main Oct 18, 2024
2 checks passed
@matevz matevz deleted the matevz/feature/gencoupons branch October 18, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZigaMr ZigaMr ZigaMr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matevz @ZigaMr